pkp/pkp-lib#10511 menu item of type series without content even when they exist in the OMP 3.4 #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt a menu item with the series type. Signed-off-by: yves <[email protected]>
jonasraoni
reviewed
Nov 15, 2024
Comment on lines
+48
to
+52
|
|
||
| $seriesTitles = []; | ||
| foreach ($series as $seriesObj) { | ||
| $seriesTitles[$seriesObj->getId()] = $seriesObj->getLocalizedTitle(); | ||
| } |
There was a problem hiding this comment.
I think the previous code can be kept, but fixed. Please, apply the fix below (there's a button somewhere on the GitHub interface 🙃).
Suggested change
| $seriesTitles = []; | |
| foreach ($series as $seriesObj) { | |
| $seriesTitles[$seriesObj->getId()] = $seriesObj->getLocalizedTitle(); | |
| } | |
| $seriesTitles = $series->mapWithKeys(fn (Section $seriesObj) => [ | |
| $seriesObj->getId() => $seriesObj->getLocalizedTitle() | |
| ])->all(); |
jonasraoni
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with the display of series without content when trying to add a series-type menu item in OMP 3.4.
Related issue: pkp/pkp-lib#10511